feat: Add IndexedDB Storage Controller #1297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1297 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 59 60 +1
Lines 5800 5815 +15
Branches 1305 1305
=========================================
+ Hits 5800 5815 +15
Continue to review full report at Codecov.
|
|
@dplewis do you believe there is a way to run the tests in ci for the scenario of using this controller (and not the default one)? |
|
@davimacedo I can't think of anything off top of my head. Might have to look into jasmine or jest. |
davimacedo
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1270
The goal of this PR is to provide a default indexedDB implementation. Users are more than welcome to create their own storage controllers if they need transactions, indexes or schema migration etc...
Uses the lightweight, idb-keyval package instead of the full idb
@FunMiles Can you give it a try?